[PATCH] qemu: hotplug: Fix the condition check for net->downscript

Michal Privoznik mprivozn at redhat.com
Mon Jun 1 15:52:52 UTC 2020


On 6/1/20 3:51 PM, Michal Privoznik wrote:
> On 5/29/20 5:52 PM, Yi Wang wrote:
>> From: Liao Pingfang <liao.pingfang at zte.com.cn>
>>
>> According to the context, here we are checking net->downscript's 
>> validity,
>>
>> Signed-off-by: Liao Pingfang <liao.pingfang at zte.com.cn>
>> ---
>>   src/qemu/qemu_hotplug.c | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
>>

> 
> Can you elaborate on this please?
> 

Ah, how could I miss the important change from net->script to 
net->downscript is beyond me :-)

I've fixed the patch to follow the pattern (i.e. not join the two 
conditions into one), and pushed.

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Sorry for the noise.

Michal




More information about the libvir-list mailing list