[PATCH 1/5] numa_conf.c: add helper functions for cpumap operations

Daniel Henrique Barboza danielhb413 at gmail.com
Mon Jun 1 17:50:37 UTC 2020


These helpers will be used in an auto-fill feature for incomplete
NUMA topologies in the next patch.

Signed-off-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
---
 src/conf/numa_conf.c     | 46 ++++++++++++++++++++++++++++++++++++++++
 src/conf/numa_conf.h     |  3 +++
 src/libvirt_private.syms |  1 +
 3 files changed, 50 insertions(+)

diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c
index 6f1257fd8e..3d766189ba 100644
--- a/src/conf/numa_conf.c
+++ b/src/conf/numa_conf.c
@@ -1373,3 +1373,49 @@ virDomainNumaGetMemorySize(virDomainNumaPtr numa)
 
     return ret;
 }
+
+
+static int
+virDomainNumaRemoveCPUsFromMap(virBitmapPtr result, virBitmapPtr exclude)
+{
+    size_t i;
+
+    for (i = 0; i < virBitmapSize(exclude); i++) {
+        if (!virBitmapIsBitSet(exclude, i))
+            continue;
+
+        if (virBitmapClearBitExpand(result, i) < 0)
+            return -1;
+    }
+
+    return 0;
+}
+
+
+int
+virDomainNumaFillCPUsInNode(virDomainNumaPtr numa, size_t node,
+                            unsigned int maxCpus)
+{
+    g_autoptr(virBitmap) maxCPUsBitmap = virBitmapNew(maxCpus);
+    size_t i;
+
+    if (node >= virDomainNumaGetNodeCount(numa))
+        return -1;
+
+    virBitmapSetAll(maxCPUsBitmap);
+
+    for (i = 0; i < numa->nmem_nodes; i++) {
+        virBitmapPtr nodeCpus = virDomainNumaGetNodeCpumask(numa, i);
+
+        if (i == node)
+            continue;
+
+        if (virDomainNumaRemoveCPUsFromMap(maxCPUsBitmap, nodeCpus) < 0)
+            return -1;
+    }
+
+    virBitmapFree(numa->mem_nodes[node].cpumask);
+    numa->mem_nodes[node].cpumask = g_steal_pointer(&maxCPUsBitmap);
+
+    return 0;
+}
diff --git a/src/conf/numa_conf.h b/src/conf/numa_conf.h
index ae3599bb8b..cdf87a87e8 100644
--- a/src/conf/numa_conf.h
+++ b/src/conf/numa_conf.h
@@ -185,3 +185,6 @@ int virDomainNumaDefCPUParseXML(virDomainNumaPtr def, xmlXPathContextPtr ctxt);
 int virDomainNumaDefCPUFormatXML(virBufferPtr buf, virDomainNumaPtr def);
 
 unsigned int virDomainNumaGetCPUCountTotal(virDomainNumaPtr numa);
+
+int virDomainNumaFillCPUsInNode(virDomainNumaPtr numa, size_t node,
+                                unsigned int maxCpus);
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index a6af44fe1c..788e08045a 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -834,6 +834,7 @@ virDomainMemoryAccessTypeFromString;
 virDomainMemoryAccessTypeToString;
 virDomainNumaCheckABIStability;
 virDomainNumaEquals;
+virDomainNumaFillCPUsInNode;
 virDomainNumaFree;
 virDomainNumaGetCPUCountTotal;
 virDomainNumaGetMaxCPUID;
-- 
2.26.2




More information about the libvir-list mailing list