bugifx: fix some wrong usage of ATTRIBUTE_NONNULL

Michal Privoznik mprivozn at redhat.com
Mon Jun 8 18:41:10 UTC 2020

On 6/8/20 7:52 PM, Daniel Henrique Barboza wrote:
> For the attached patch:
> Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>

I'm not against the diff, but ...

> On 6/6/20 7:30 AM, Bihong Yu wrote:
>> There are some wrong usage of ATTRIBUTE_NONNULL, which may cause the 
>> compilation fail. The
>> ATTRIBUTE_NONNULL is the define of __attribute__((__nonnull__(m))), 
>> which declares that the
>> input pointer parameter of funciton should not be NULL. If we declare 
>> some input pointer
>> parameter of the function is ATTRIBUTE_NONNULL, the function should 
>> not redundancy check of
>> the pointer parameter. And the ATTRIBUTE_NONNULL can only be using to 
>> pointer.

This ^^ is unrelated (even though it's a mistake as there is another 
patch with this explanation that fixes ATTRIBUTE_NONNULL),

>>> From 55cd85345b2dc50f44c1e382563482d40142382b Mon Sep 17 00:00:00 2001
>> From: yubihong <yubihong at huawei.com>
>> Date: Fri, 24 Apr 2020 17:44:43 +0800
>> Subject: [PATCH] qemu: fix code format problem

But this is not qemu related. Can you please resend the patch with 
proper prefix? E.g. libvirt-domain: Fix indentation

And mention in the commit message what functions are fixed?


More information about the libvir-list mailing list