[libvirt PATCH] ci: Reduce number of stages

Ján Tomko jtomko at redhat.com
Wed Jun 10 13:32:15 UTC 2020

On a Wednesday in 2020, Daniel P. Berrangé wrote:
>On Wed, Jun 10, 2020 at 01:51:29PM +0200, Peter Krempa wrote:
>> On Wed, Jun 10, 2020 at 13:33:01 +0200, Andrea Bolognani wrote:
>> [...]
>> > Building artifacts in a separate pipeline stage also doesn't have any
>> > advantages, and only delays further stages by a couple of minutes.
>> > The only job that really makes sense in its own stage is the DCO
>> > check, because it's extremely fast (less than 1 minute) and, if that
>> > fails, we can avoid kicking off all other jobs.
>> On the contrary I think that the DCO check should be made after builds
>> as that usually forces users to add a sign-off just to bypass that check
>> if they want to sanity check their series.
>Missing signoff is quite common for new contributors, so it was put as
>the first check so that get quick notification of this mistake.
>> Since the lack of a sign off can be effectively used as a mark for an
>> patch that is not ready to be pushed, but a build-check is still needed.
>> This adds a pointless hurdle in using the CI and also removes one of the
>> meaningful uses to have a sign off checker.
>That kind of usage of signoff is not really required in a merge request
>workflow. You won't typically open the merge request in the first place
>if code isn't ready, but if you did, then there's explicit "WIP" flag for
>merge requests to achieve this. Once libvirt.git uses merge request, we
>will fully block all ability to push directly to git.

I think we have a long way to go until merge requests are usable without
pushing directly to git.


>|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
>|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
>|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200610/8982dccf/attachment-0001.sig>

More information about the libvir-list mailing list