[PATCH 7/7] Remove use of variables passed only to 'VIR_FREE'

Ján Tomko jtomko at redhat.com
Thu Jun 11 12:07:15 UTC 2020


On a Thursday in 2020, Ján Tomko wrote:
>On a Thursday in 2020, Peter Krempa wrote:
>>Compilers are not very good at detecting this problem. Fixed by manual
>>inspection of compilation warnings after replacing 'VIR_FREE' with an
>>empty macro.
>>
>
>Also, I see you're building without vz_sdk, I found two more occurrences

False alarm, it did not inspect the macro where it was used correctly.

Jano

>with the following coccinelle spatch:
>
>@@
>identifier i;
>type T;
>constant C;
>@@
>
>-T i = C;
><+... when != i
>-VIR_FREE(i);
>...+>
>
>Jano


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200611/026ea5f4/attachment-0001.sig>


More information about the libvir-list mailing list