[PATCH 1/3] *** DO NOT APPLY UPSTREAM ***

Michal Privoznik mprivozn at redhat.com
Mon Jun 15 12:46:42 UTC 2020


On 6/15/20 2:06 PM, Peter Krempa wrote:
> On Mon, Jun 15, 2020 at 13:32:34 +0200, Michal Privoznik wrote:
>> This is a demo of the problem. Set up two NATed networks with
>> dnsmasq and start a domain with two interfaces, one from each
>> network. Only one network will report DHCP lease in 'virsh
>> net-dhcp-leases'.
>>
>> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> 
> I suggest you make use of the actual useful uses of a sign-off and that
> is to omit it for patches which are not meant to be pushed upstream. The
> pre-push hook will reject accidentally pushing it.
> 

Ah, sure; It's just that I have this alias 'cs' which does commit + sign 
off and I am so used to commit using that.

BTW: did we migrate these pre-commit hooks to gitlab too?

Michal




More information about the libvir-list mailing list