[libvirt PATCH] ci: Makefile: Add distcheck target

Michal Privoznik mprivozn at redhat.com
Wed Jun 17 12:01:45 UTC 2020


On 6/17/20 12:00 PM, Erik Skultety wrote:
>>From time to time we see failures in our gitlab pipelines that we as
> developers don't see locally, simply because we don't run "make
> distcheck" that often which is what the gitlab containers run and which
> can indeed reveal mistakes like not shipping the necessary test data.
> Since most of us prefer local testing over waiting for the gitlab
> pipeline to finish, introduce the distcheck target to the CI which we
> have inside the repo under ci/.
> 
> Signed-off-by: Erik Skultety <eskultet at redhat.com>
> ---
>   ci/Makefile | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/ci/Makefile b/ci/Makefile
> index 7840cc8d89..e1c626ed34 100644
> --- a/ci/Makefile
> +++ b/ci/Makefile
> @@ -239,6 +239,9 @@ ci-build@%:
>   ci-check@%:
>   	$(MAKE) -C $(CI_ROOTDIR) ci-build@$* CI_MAKE_ARGS="check"
>   
> +ci-distcheck@%:
> +	$(MAKE) -C $(CI_ROOTDIR) ci-build@$* CI_MAKE_ARGS="distcheck"
> +
>   ci-list-images:
>   	@echo
>   	@echo "Available x86 container images:"
> 

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal




More information about the libvir-list mailing list