[libvirt PATCH 1/3] lxc: drop compat code for mount constants

Daniel P. Berrangé berrange at redhat.com
Wed Jun 17 15:51:51 UTC 2020


Given our supported platform matrix, we can safely assume that
all the mount constants we need are defined by the system
headers.

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
---
 src/lxc/lxc_container.c  | 17 -----------------
 src/lxc/lxc_controller.c |  8 --------
 2 files changed, 25 deletions(-)

diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c
index 77df49ea75..b0a6deeb56 100644
--- a/src/lxc/lxc_container.c
+++ b/src/lxc/lxc_container.c
@@ -527,23 +527,6 @@ lxcContainerRenameAndEnableInterfaces(virDomainDefPtr vmDef,
 /*_syscall2(int, pivot_root, char *, newroot, const char *, oldroot)*/
 extern int pivot_root(const char * new_root, const char * put_old);
 
-#ifndef MS_REC
-# define MS_REC          16384
-#endif
-
-#ifndef MNT_DETACH
-# define MNT_DETACH      0x00000002
-#endif
-
-#ifndef MS_PRIVATE
-# define MS_PRIVATE              (1<<18)
-#endif
-
-#ifndef MS_SLAVE
-# define MS_SLAVE                (1<<19)
-#endif
-
-
 static int lxcContainerUnmountSubtree(const char *prefix,
                                       bool isOldRootFS)
 {
diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
index 4672920574..594d7f7e17 100644
--- a/src/lxc/lxc_controller.c
+++ b/src/lxc/lxc_controller.c
@@ -2052,14 +2052,6 @@ static int lxcSetPersonality(virDomainDefPtr def)
     return 0;
 }
 
-#ifndef MS_REC
-# define MS_REC          16384
-#endif
-
-#ifndef MS_SLAVE
-# define MS_SLAVE              (1<<19)
-#endif
-
 /* Create a private tty using the private devpts at PTMX, returning
  * the master in *TTYMASTER and the name of the slave, _from the
  * perspective of the guest after remounting file systems_, in
-- 
2.24.1




More information about the libvir-list mailing list