[libvirt PATCH] util: remove outdated comment from virLogFormatString

Ján Tomko jtomko at redhat.com
Thu Jun 18 13:10:19 UTC 2020


Introduced by commit 72ab0b6dc8129a388aff260a6e444d48495b0e93 which
added some code depending on libvirt's log format string into
qemuProcessReadLogOutput. This function was deleted by commit
932534e85f34a479c7eac174e997bfd9c85bd22d later.

Drop the comment.

Signed-off-by: Ján Tomko <jtomko at redhat.com>
Closes: https://gitlab.com/libvirt/libvirt/-/issues/35
---
Pushed as trivial.

 src/util/virlog.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/src/util/virlog.c b/src/util/virlog.c
index e4944d1258..2c18eeed03 100644
--- a/src/util/virlog.c
+++ b/src/util/virlog.c
@@ -421,13 +421,6 @@ virLogFormatString(char **msg,
                    virLogPriority priority,
                    const char *str)
 {
-    /*
-     * Be careful when changing the following log message formatting, we rely
-     * on it when stripping libvirt debug messages from qemu log files. So when
-     * changing this, you might also need to change the code there.
-     * virLogFormatString() function name is mentioned there so it's sufficient
-     * to just grep for it to find the right place.
-     */
     if ((funcname != NULL)) {
         *msg = g_strdup_printf("%llu: %s : %s:%d : %s\n",
                                virThreadSelfID(), virLogPriorityString(priority),
-- 
2.25.4




More information about the libvir-list mailing list