[PATCH] qemu: auto-assign hostdev interface devices to PCIe

Paulo de Rezende Pinatti ppinatti at linux.ibm.com
Thu Jun 18 15:09:06 UTC 2020



On 17/06/20 23:17, Laine Stump wrote:
[...]
> 
> (Note to Paulo - I realize this doesn't describe exactly what happens
> on s390, since the default interface model in that case is "virtio"
> rather than "rtl8139", and this patch should actually cause no
> behavior change on S390. I'm Cc'ing you since you're the author of the
> other patch I mention in the commit message, and also so you can try
> running your same tests with this patch added, and verify that it
> really doesn't break anything for S390.)
> 

Hi Laine,

Thanks for the note, I ran the same tests with this patch and can 
confirm it still works for S390.

> 
>   src/qemu/qemu_domain_address.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c
> index 07431343ed..05cf251cd5 100644
> --- a/src/qemu/qemu_domain_address.c
> +++ b/src/qemu/qemu_domain_address.c
> @@ -734,6 +734,14 @@ qemuDomainDeviceCalculatePCIConnectFlags(virDomainDeviceDefPtr dev,
>           if (net->model == VIR_DOMAIN_NET_MODEL_E1000E)
>               return pcieFlags;
>   
> +        /* the only time model can be "unknown" is for type='hostdev'
> +         * or for type='network' where the network is a pool of
> +         * hostdev devices. These will always be pcie on the host, and
> +         * should be pcie in the guest if it supports pcie.
> +         */
> +        if (net->model == VIR_DOMAIN_NET_MODEL_UNKNOWN)
> +            return pcieFlags;
> +
>           return pciFlags;
>       }
>   
> 

-- 
Best regards,

Paulo de Rezende Pinatti




More information about the libvir-list mailing list