[PATCH 16/32] qemuBlockBitmapChainIsValid: Adjust to new semantics of bitmaps

Eric Blake eblake at redhat.com
Thu Jun 18 16:08:51 UTC 2020


On 6/15/20 12:10 PM, Peter Krempa wrote:
> Reject duplicates and other problematic bitmaps according to the new
> semantics of bitmap use in libvirt.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   src/qemu/qemu_block.c | 38 +++++++++++++++++++++++---------------
>   1 file changed, 23 insertions(+), 15 deletions(-)
> 
> diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
> index 6f9c7071c9..83e3df9601 100644
> --- a/src/qemu/qemu_block.c
> +++ b/src/qemu/qemu_block.c
> @@ -2850,41 +2850,49 @@ qemuBlockGetNamedNodeData(virDomainObjPtr vm,
>   /**
>    * qemuBlockBitmapChainIsValid:
>    *
> - * Validates that the backing chain of @src contains proper consistent bitmap
> - * data for a chain of bitmaps named @bitmapname.
> + * Validates that the backing chain of @src contains bitmaps which libvirt will
> + * consider as properly corresponding to a checkpoint named @bitmapname.
>    *
> - * A valid chain:
> - * 1) bitmaps of same name are in a consecutive subset of images without gap
> - * 2) don't have any inconsistent bitmaps
> + * The bitmaps need to:
> + * 1) start from the top image @src
> + * 2) must be present in consecutive layers
> + * 3) all must be active, persistent and not incosistent

inconsistent

Otherwise,
Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list