[PATCH 23/32] qemu: backup: Rewrite backup bitmap handling to the new bitmap semantics

Eric Blake eblake at redhat.com
Thu Jun 18 21:41:02 UTC 2020


On 6/15/20 12:10 PM, Peter Krempa wrote:
> Reuse qemuBlockGetBitmapMergeActions which allows to remove the ad-hoc

allows the removal of the

> iplementatio of bitmap merging for backup. The new approach is simpler

implementation

> and also more robust in case some of the bitmaps break as they remove
> the dependancy on the whole chain of bitmaps working.

dependency

> 
> The new approach also allows backups if a snapshot is created outside of
> libvirt.
> 
> Additionally the code is greatly simplified.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   src/qemu/qemu_backup.c                        | 220 +++---------------
>   src/qemu/qemu_backup.h                        |  12 +-
>   tests/qemublocktest.c                         |  86 ++-----
>   .../backupmerge/empty-out.json                |   4 +-
>   4 files changed, 63 insertions(+), 259 deletions(-)
> 
Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list