[libvirt PATCH 23/23] build: add syntax-check rules for undesirable terms

Daniel P. Berrangé berrange at redhat.com
Fri Jun 19 09:33:00 UTC 2020


We don't check for "master", because there are too many
cases that we're not trying to eliminate at this time.

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
---
 build-aux/syntax-check.mk | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 2e49b5172e..50b15e114a 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -1922,6 +1922,16 @@ sc_prohibit_path_max_allocation:
 	halt='Avoid stack allocations of size PATH_MAX'			\
 	  $(_sc_search_regexp)
 
+sc_prohibit_whitelist_blacklist:
+	@prohibit='(white-?list|black-?list)' \
+	halt='Avoid the terms "whitelist" and "blacklist"' \
+	  $(_sc_search_regexp)
+
+sc_prohibit_slave:
+	@prohibit='slave' \
+	halt='Avoid the term "slave"' \
+	  $(_sc_search_regexp)
+
 ifneq ($(_gl-Makefile),)
 syntax-check: spacing-check test-wrap-argv \
 	prohibit-duplicate-header mock-noinline group-qemu-caps \
@@ -2128,3 +2138,9 @@ exclude_file_name_regexp--sc_prohibit_backslash_alignment = \
 
 exclude_file_name_regexp--sc_prohibit_select = \
   ^build-aux/syntax-check\.mk|src/util/vireventglibwatch\.c$$
+
+exclude_file_name_regexp--sc_prohibit_whitelist_blacklist = \
+  ^(build-aux/syntax-check\.mk|po/.*\.pot?|src/util/virkmod\.c|src/qemu/qemu_domain\.c)$$
+
+exclude_file_name_regexp--sc_prohibit_slave = \
+  ^build-aux/syntax-check\.mk|po/.*\.pot?|tests/qemucapabilitiesdata/.*\.replies|docs/apps.html.in|tests/bhyve.*|docs/drvbhyve.html.in|docs/formatdomain.html.in|docs/schemas/domaincommon.rng|src/conf/domain_conf\.c|src/interface/interface_backend_udev\.c|src/security/apparmor/usr\.sbin\.libvirtd\.in$$
-- 
2.24.1




More information about the libvir-list mailing list