[libvirt PATCH 08/23] util: rename method to virKModIsProhibited

Peter Krempa pkrempa at redhat.com
Fri Jun 19 10:14:46 UTC 2020


On Fri, Jun 19, 2020 at 10:32:45 +0100, Daniel Berrange wrote:
> This naming better matches the semantics usage of the test.

I this instance I disagree that it's better as it's diverging from the
terminology used by modprobe and doesn't really describe it any better
than it did before, so I'd prefer if it's not sold as being better.

> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  src/libvirt_private.syms |  2 +-
>  src/util/virfile.c       |  2 +-
>  src/util/virkmod.c       | 24 ++++++++++++------------
>  src/util/virkmod.h       |  2 +-
>  src/util/virpci.c        |  4 ++--
>  5 files changed, 17 insertions(+), 17 deletions(-)

I don't have problem with the change per-se, just the justification for
it.

Reviewed-by: Peter Krempa <pkrempa at redhat.com>




More information about the libvir-list mailing list