[libvirt PATCH v4 00/12] Add ability to create mediated devices in libvirt

Daniel P. Berrangé berrange at redhat.com
Fri Jun 19 11:06:36 UTC 2020


On Fri, Jun 19, 2020 at 10:35:12AM +0200, Michal Privoznik wrote:
> On 6/19/20 9:22 AM, Erik Skultety wrote:
> > On Thu, Jun 18, 2020 at 04:05:53PM -0500, Jonathon Jongsma wrote:
> > > This is the first portion of an effort to support persistent mediated devices
> > > with libvirt. This first series simply enables creating and destroying
> > > non-persistent mediated devices via the virNodeDeviceCreateXML() and
> > > virNodeDeviceDestroy() functions. The 'mdevctl' utility[1] provides the backend
> > > implementation.
> > > 
> > > Hopefully these are the last changes and version can simply be pushed upstream.
> > > 
> > > Changes in v4:
> > >   - coding style / spacing fixes
> > >   - remove 'persist' arg from start command
> > >   - fixed distcheck failure by including test data dir in EXTRA_DIST
> > >   - Add an item to NEWS.rst
> > > 
> > > [1] https://github.com/mdevctl/mdevctl
> > > 
> > 
> > I'll give Michal a chance to have a final look before I push this.
> > Good work.
> > 
> > Series:
> > Reviewed-by: Erik Skultety <eskultet at redhat.com>
> > 
> 
> Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

This appears to have broken the build because the nodedev driver so file
has gained a bogus version number

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list