[libvirt PATCH 23/23] build: add syntax-check rules for undesirable terms

Ján Tomko jtomko at redhat.com
Fri Jun 19 12:11:09 UTC 2020


On a Friday in 2020, Peter Krempa wrote:
>On Fri, Jun 19, 2020 at 10:33:00 +0100, Daniel Berrange wrote:
>> We don't check for "master", because there are too many
>> cases that we're not trying to eliminate at this time.
>>

Even if you consider the terms undesirable, consider using them in the
commit summary instead of mentioning what you're not trying to do.

>> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
>> ---
>>  build-aux/syntax-check.mk | 16 ++++++++++++++++
>>  1 file changed, 16 insertions(+)
>
>I don't think there's a technical reason forbiding these and it's almost
>borderline censorship. I refuse to put my R-b on this one.
>

Given how many files are excepted, I think it's a waste of electricty to
even check for these.

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200619/84e900f3/attachment-0001.sig>


More information about the libvir-list mailing list