[libvirt PATCH 23/23] build: add syntax-check rules for undesirable terms

Daniel P. Berrangé berrange at redhat.com
Fri Jun 19 12:29:07 UTC 2020

On Fri, Jun 19, 2020 at 08:45:41AM -0300, Daniel Henrique Barboza wrote:
> Is this patch really necessary?
> Manually removing the now undesirable terms it's okay (I mean, not quite,
> but I'm too tired of this same discussion over and over again everywhere,
> so I give up), because at least it requires a bit of thought and analysis.
> Prohibiting the words altogether will eliminate valid use. With this patch
> I'll now be forbid to write a comment such as
> /* This is code is needed because module X is in the blacklist */

Yes, that is entirely the intention because there's no need to
add such a comment in the first place. It can easily be written as

 /* This is code is needed because module X is prohibited */

> Unless I'm doing a comment in qemu_domain.c or virkmod.c. This is extreme, and
> I don't think the existing Libvirt syntax-check mechanics will be able to detect
> allowed usage of these terms.

The only allowed usage of the terms is that which already exists in the
code which are unable to be eliminated due to interactions with external
tools/API. No new instances should be introduced, which is what the
syntax-check rule validates.

|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

More information about the libvir-list mailing list