[libvirt PATCH] nodedev: Makefile: Use AM_LDFLAGS_MOD_NOUNDEF with the installed library

Erik Skultety eskultet at redhat.com
Fri Jun 19 13:03:50 UTC 2020


On Fri, Jun 19, 2020 at 01:59:48PM +0100, Daniel P. Berrangé wrote:
> On Fri, Jun 19, 2020 at 02:55:09PM +0200, Erik Skultety wrote:
> > Rather than using the AM_LDFLAGS_MOD_NOUNDEF options with the noinstall
> > library that will come out of libtool from
> > libvirt_driver_nodedev_impl_la, use it with the installed version
> > libvirt_driver_nodedev_la.
> >
> > Broken-by-commit: c44bffb9
> > Fixes: https://ci.centos.org/job/libvirt-rpm/systems=libvirt-fedora-32/1155/
> >
> > Signed-off-by: Erik Skultety <eskultet at redhat.com>
> > ---
> > Technically a build fix, but I'd like one more pair of eyes to look at this,
> > especially if they understand libtool.
> >
> >  src/node_device/Makefile.inc.am | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/src/node_device/Makefile.inc.am b/src/node_device/Makefile.inc.am
> > index 5993165b56..abe26b23bf 100644
> > --- a/src/node_device/Makefile.inc.am
> > +++ b/src/node_device/Makefile.inc.am
> > @@ -37,6 +37,7 @@ if WITH_NODE_DEVICES
> >  noinst_LTLIBRARIES += libvirt_driver_nodedev_impl.la
> >  libvirt_driver_nodedev_la_SOURCES =
> >  libvirt_driver_nodedev_la_LIBADD = libvirt_driver_nodedev_impl.la
> > +libvirt_driver_nodedev_la_LDFLAGS = $(AM_LDFLAGS_MOD_NOUNDEF)
>
> ...and remove it from the libvirt_driver_nodedev_impl_la_LDFLAGS

Damn, I must have dropped that from the git stage by accident, will do, do I
need to respin?

Erik




More information about the libvir-list mailing list