[PATCH 28/32] qemublocktest: Add 'snapshots' tests for block commit bitmap handling

Eric Blake eblake at redhat.com
Fri Jun 19 14:40:09 UTC 2020


On 6/15/20 12:10 PM, Peter Krempa wrote:
> Simulate commit between all the combinations of layers in the
> 'snapshots' case to see whether the code merges the correct bitmaps with
> the correct depth of temporary bitmaps.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   tests/qemublocktest.c                         |  14 ++
>   .../bitmapblockcommit/snapshots-1-2           | 105 +++++++++++
>   .../bitmapblockcommit/snapshots-1-3           | 131 ++++++++++++++
>   .../bitmapblockcommit/snapshots-1-4           | 163 +++++++++++++++++
>   .../bitmapblockcommit/snapshots-1-5           | 167 ++++++++++++++++++
>   .../bitmapblockcommit/snapshots-2-3           |  65 +++++++
>   .../bitmapblockcommit/snapshots-2-4           |  97 ++++++++++
>   .../bitmapblockcommit/snapshots-2-5           | 101 +++++++++++
>   .../bitmapblockcommit/snapshots-3-4           |  62 +++++++
>   .../bitmapblockcommit/snapshots-3-5           |  66 +++++++
>   .../bitmapblockcommit/snapshots-4-5           |  16 ++
>   11 files changed, 987 insertions(+)
>   create mode 100644 tests/qemublocktestdata/bitmapblockcommit/snapshots-1-2
>   create mode 100644 tests/qemublocktestdata/bitmapblockcommit/snapshots-1-3
>   create mode 100644 tests/qemublocktestdata/bitmapblockcommit/snapshots-1-4
>   create mode 100644 tests/qemublocktestdata/bitmapblockcommit/snapshots-1-5
>   create mode 100644 tests/qemublocktestdata/bitmapblockcommit/snapshots-2-3
>   create mode 100644 tests/qemublocktestdata/bitmapblockcommit/snapshots-2-4
>   create mode 100644 tests/qemublocktestdata/bitmapblockcommit/snapshots-2-5
>   create mode 100644 tests/qemublocktestdata/bitmapblockcommit/snapshots-3-4
>   create mode 100644 tests/qemublocktestdata/bitmapblockcommit/snapshots-3-5
>   create mode 100644 tests/qemublocktestdata/bitmapblockcommit/snapshots-4-5
> 

Lots of combinations, but that serves for good regression prevention.
Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list