[PATCH v3 11/19] audio: deprecate -soundhw pcspk
philmd at redhat.com
Mon Jun 22 13:07:50 UTC 2020
On 6/22/20 2:59 PM, Thomas Huth wrote:
> On 22/06/2020 13.29, Gerd Hoffmann wrote:
>> Add deprecation message to the audio init function.
>> Factor out audio initialization and call that from
>> both audio init and realize, so setting audiodev via
>> -global is enough to properly initialize pcspk.
>> Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>
>> hw/audio/pcspk.c | 24 +++++++++++++++++++++---
>> 1 file changed, 21 insertions(+), 3 deletions(-)
>> +static int pcspk_audio_init_soundhw(ISABus *bus)
>> + PCSpkState *s = pcspk_state;
>> + warn_report("'-soundhw pcspk' is deprecated, "
>> + "please set a backend using '-global isa-pcspk.audiodev=<name>' instead");
Markus's "Crazy shit around -global (pardon my french)"
series instead suggest to use '-device ...':
Could that work here?
>> + return pcspk_audio_init(s);
> While "-soundhw pcspk" is quite easy to use for the average user, I
> think the "-global" options will be quite hard to figure out, especially
> once this deprecation message got removed again when -soundhw has been
> deleted. Could you maybe add a description how to configure the
> pc-speaker to docs/system/target-i386-desc.rst.inc, too?
More information about the libvir-list