[PATCH 3/3] leaseshelper: Report more errors

Daniel P. Berrangé berrange at redhat.com
Wed Jun 24 13:56:01 UTC 2020


On Mon, Jun 15, 2020 at 01:32:36PM +0200, Michal Privoznik wrote:
> Some functions or code paths that may fail don't report error
> (e.g. when acquiring PID file fails) leading to a silent quit
> of the leaseshelper. This makes it super hard for us and users
> to debug what is happening. Fortunately, dnsmasq captures both
> stdout and stderr so we can write an error message there.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/network/leaseshelper.c | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list