[PATCH 15/25] network: use proper arg type when calling virNetDevSetOnline()

Laine Stump laine at redhat.com
Thu Jun 25 03:34:04 UTC 2020


The 2nd arg to this function is a bool, not an int.

Signed-off-by: Laine Stump <laine at redhat.com>
---
 src/network/bridge_driver.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index 1dee2fac6e..cbf5f05f30 100644
--- a/src/network/bridge_driver.c
+++ b/src/network/bridge_driver.c
@@ -2427,7 +2427,7 @@ networkStartNetworkVirtual(virNetworkDriverStatePtr driver,
         goto error;
 
     /* Bring up the bridge interface */
-    if (virNetDevSetOnline(def->bridge, 1) < 0)
+    if (virNetDevSetOnline(def->bridge, true) < 0)
         goto error;
 
     devOnline = true;
@@ -2505,7 +2505,7 @@ networkStartNetworkVirtual(virNetworkDriverStatePtr driver,
     }
 
     if (devOnline)
-        ignore_value(virNetDevSetOnline(def->bridge, 0));
+        ignore_value(virNetDevSetOnline(def->bridge, false));
 
     if (firewalRulesAdded &&
         def->forward.type != VIR_NETWORK_FORWARD_OPEN)
@@ -2558,7 +2558,7 @@ networkShutdownNetworkVirtual(virNetworkDriverStatePtr driver,
             ignore_value(virNetDevTapDelete(macTapIfName, NULL));
     }
 
-    ignore_value(virNetDevSetOnline(def->bridge, 0));
+    ignore_value(virNetDevSetOnline(def->bridge, false));
 
     if (def->forward.type != VIR_NETWORK_FORWARD_OPEN)
         networkRemoveFirewallRules(def);
-- 
2.25.4




More information about the libvir-list mailing list