[PATCH 03/25] conf: refactor virDomainBlkioDeviceParseXML to remove possible NULL dereference

Laine Stump laine at redhat.com
Fri Jun 26 22:58:58 UTC 2020


On 6/26/20 6:54 PM, Laine Stump wrote:
> On 6/25/20 6:44 PM, Ján Tomko wrote:
>
>> and give a possibility of assigning the path directly
>> to 'path', without the extra steal_pointer.
>
>
> I don't follow there - if you assign directly from xmlNodeGetContent() 
> into path, then you'll need to duplicate the virReportOOMError().


Sigh. Nevermind. It had already been several days since I wrote the 
code, so I'd completely forgotten it and hadn't looked back at the 
bottom yet (where I would have seen the "extra steal pointer" you mention).


Now I get it.





More information about the libvir-list mailing list