[PATCH 1/1] domain_conf.c: skip checking ZPCI address is incomplete if not present

Andrea Bolognani abologna at redhat.com
Sat Jun 27 13:32:37 UTC 2020

On Fri, 2020-06-26 at 18:49 -0300, Daniel Henrique Barboza wrote:
> Commit 076591009ad1 ("conf: fix zPCI address auto-generation on
> s390") is doing a check for virZPCIDeviceAddressIsIncomplete()
> prior to checking if the device has a ZPCI address at all. This
> results in errors like these when starting Libvirt:
> error : virDomainDeviceInfoFormat:7527 : internal error:
> Missing uid or fid attribute of zPCI address
> Fix it by moving virZPCIDeviceAddressIsIncomplete() after the
> check done by virZPCIDeviceAddressIsPresent().
> Fixes: 076591009ad11ec108521b52a4945d0f895fa160
> CC: Bjoern Walk <bwalk at linux.ibm.com>
> CC: Boris Fiuczynski <fiuczy at linux.ibm.com>
> CC: Shalini Chellathurai Saroja <shalini at linux.ibm.com>
> CC: Andrea Bolognani <abologna at redhat.com>
> Signed-off-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
> ---
>  src/conf/domain_conf.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Good catch!

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

and pushed with an ever so slightly tweaked commit message.

In the future, please don't include CC tags in your commits: removing
them results in extra work when picking up a patch, and it's also
generally not considered very polite to CC individual developers.
Everyone is subscribed to the list anyway :)

Andrea Bolognani / Red Hat / Virtualization

More information about the libvir-list mailing list