[PATCH 1/3] qemuhotplugtest: Free monitor iff successfully initialized

Andrea Bolognani abologna at redhat.com
Mon Jun 29 09:33:38 UTC 2020


On Mon, 2020-06-29 at 09:43 +0200, Michal Privoznik wrote:
> If initializing test monitor in testQemuHotplugCpuPrepare()
> fails, the control jumps to error label where
> testQemuHotplugCpuDataFree() is called. But since the data->mon
> is NULL due to aforementioned failure,
> qemuMonitorTestGetMonitor() dereferences a NULL pointer leading
> to a SIGSEGV.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  tests/qemuhotplugtest.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Reviewed-by: Andrea Bolognani <abologna at redhat.com>

and safe for freeze.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list