[PATCH v2 for 6.5.0] domain_conf: Remove zPCI validation from formatter
abologna at redhat.com
Mon Jun 29 11:07:33 UTC 2020
On Mon, 2020-06-29 at 12:57 +0200, Michal Privoznik wrote:
> In 076591009ad a validation code was added to
> virDomainDeviceInfoFormat() which reports an error if zPCI
> address entered in was incomplete. But, there are two problems
> with this approach.
> The first problem is the placement of the code - it doesn't
> belong into XML formatter rather than XML validator.
> The second one is that at the point of formatting XML the post
> parse callback has run and thus filled in required info.
> Therefore this check can never do something useful and instead of
> moving it into validator, it's removed completely.
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> This is v2 of:
> diff to v1:
> - Instead of moving the check to validator remove it completely (per
> discussion in v1)
> src/conf/domain_conf.c | 4 ----
> 1 file changed, 4 deletions(-)
Reviewed-by: Andrea Bolognani <abologna at redhat.com>
and safe for freeze.
Andrea Bolognani / Red Hat / Virtualization
More information about the libvir-list