[PATCH 0/5] alloc: Don't mask use of uninitialized variables in VIR_FREE

Peter Krempa pkrempa at redhat.com
Thu Mar 5 09:51:57 UTC 2020


Neither GCC nor clang report warnings if pointer passed to VIR_FREE is
uninitialized. This is probably caused by our internal implementation
which mangles the pointer to it.

Fix all offenders and replace VIR_FREE's internals with g_clear_pointer.

Peter Krempa (5):
  virNetworkPortDefSaveStatus: Fix potentially uninitialized 'path' by
    refactoring cleanup
  virLXCProcessSetupNamespaceName: Fix potential uninitialized free of
    'path'
  cmdDomHostname: Fix uninitialized use of 'hostname' by refactoring
    cleanup
  testQemuMonitorJSONqemuMonitorJSONGetTargetArch: Fix uninitialized use
    of 'arch'
  VIR_ALLOC: Replace internals by g_clear_pointer

 src/conf/virnetworkportdef.c | 19 +++++++------------
 src/libvirt_private.syms     |  1 -
 src/lxc/lxc_process.c        |  3 +--
 src/util/viralloc.c          | 21 ++-------------------
 src/util/viralloc.h          |  7 +------
 tests/qemumonitorjsontest.c  | 14 +++++---------
 tools/virsh-domain.c         | 18 ++++++------------
 7 files changed, 22 insertions(+), 61 deletions(-)

-- 
2.24.1




More information about the libvir-list mailing list