[PATCH] virDomainDiskTranslateSourcePool: Check for disk type correctly

Peter Krempa pkrempa at redhat.com
Mon Mar 9 15:56:23 UTC 2020


On Mon, Mar 09, 2020 at 16:50:52 +0100, Michal Privoznik wrote:
> When rewriting the virDomainDiskTranslateSourcePool() function in
> v6.1.0-rc1~184 a typo was introduced. Previously, we allowed
> startup policy only for those volumes which translated to
> VIR_STORAGE_TYPE_FILE. But starting with the referenced commit,
> the value we checked for was changed to VIR_STORAGE_VOL_FILE
> which comes from a different enum and has a different value too.
> This is wrong, because virStorageSourceGetActualType() returns a
> value from the original enum.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1811728
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>

Oops.

Reviewed-by: Peter Krempa <pkrempa at redhat.com>




More information about the libvir-list mailing list