[RFC] qemu: convert DomainLogContext class to use GObject

Peter Krempa pkrempa at redhat.com
Wed Mar 11 08:25:56 UTC 2020


On Tue, Mar 10, 2020 at 18:23:42 +0100, Ján Tomko wrote:
> On a Tuesday in 2020, Daniel P. Berrangé wrote:

[...]

> > > While ugly I still think that for greppability/searchability it's way
> > > better to keep the object name using camel case. In the end as you've
> > > pointed out it's just for the specific methods named above. Making it
> > > look ugly is IMO less worse than missing something when trying to
> > > understand how the code works.
> > 
> > IIRC, Ján raised the issue of avoiding mixed camelcase/snakecase
> > namings originally, so CC'ing to see if he's ok with changing
> > back again ?
> 
> I don't care about it enough to send another e-mail after this one :)
> 
> However the case convetion is a part of the macro documentation:
> https://developer.gnome.org/gobject/unstable/gobject-Type-Information.html#G-DEFINE-TYPE:CAPS

Hmm, sorry I didn't really look into that in the first place so thanks
for teaching me. While I don't like yet another convention, I'm okay
with the naming in this patch based on the above.




More information about the libvir-list mailing list