[libvirt PATCH 1/3] domain_conf: fix ATTRIBUTE_NONNULL for virDomainDefFormat

Pavel Hrdina phrdina at redhat.com
Wed Mar 11 12:13:43 UTC 2020


Commit <92d412149ce563da48ba299ec49c07d825370cbf> introduced `xmlopt`
attribute to `virDomainDefFormat` function and marked it as NONNULL
which is not correct because in hyperv dirver we call that function
with NULL as `xmlopt`.

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---
 src/conf/domain_conf.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index 91b776c28a..8d6bc5057d 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -3132,7 +3132,7 @@ unsigned int virDomainDefFormatConvertXMLFlags(unsigned int flags);
 char *virDomainDefFormat(virDomainDefPtr def,
                          virDomainXMLOptionPtr xmlopt,
                          unsigned int flags)
-    ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
+    ATTRIBUTE_NONNULL(1);
 char *virDomainObjFormat(virDomainObjPtr obj,
                          virDomainXMLOptionPtr xmlopt,
                          unsigned int flags)
-- 
2.24.1




More information about the libvir-list mailing list