[PATCH 3/5] qemuDomainBlockCopyCommon: Record updated flags to block job

Eric Blake eblake at redhat.com
Wed Mar 11 15:58:49 UTC 2020


On 3/10/20 10:54 AM, Peter Krempa wrote:
> For a long time we've masked out VIR_DOMAIN_BLOCK_COPY_SHALLOW if
> there's no backing chain for the copied disk to simplify the code.
> 
> One of the refacors of caused that we no longer update the 'flags'

s/refacors of/refactors of XXX/ (typo, plus figuring out what you meant 
for XXX)

> variable just the local copies. This was okay until in ccd4228afff I
> started storing the job flags in the block job data.
> 
> Given that we modify how we call qemu we also should modify @flags so
> that the correct value is recorded in the block job data.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   src/qemu/qemu_driver.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 

Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list