[PATCH 30/30] qemu: Pass through arguments of 'ssh' block driver used by libguestfs

Ján Tomko jtomko at redhat.com
Fri Mar 13 06:08:46 UTC 2020


On a Monday in 2020, Peter Krempa wrote:
>We currently don't model the 'ssh' protocol properties properly and
>since it seems impossible for now (agent path passed via environment
>variable). To allow libguestfs to work as it used in pre-blockdev era we
>must carry the properties over to the command line. For this instance we
>just store it internally and format it back.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_block.c                              | 10 ++++++++++
> src/util/virstoragefile.c                          | 13 +++++++++++++
> src/util/virstoragefile.h                          |  5 +++++
> tests/qemublocktest.c                              |  1 +
> .../jsontojson/ssh-passthrough-libguestfs-in.json  |  1 +
> .../jsontojson/ssh-passthrough-libguestfs-out.json | 14 ++++++++++++++
> 6 files changed, 44 insertions(+)
> create mode 100644 tests/qemublocktestdata/jsontojson/ssh-passthrough-libguestfs-in.json
> create mode 100644 tests/qemublocktestdata/jsontojson/ssh-passthrough-libguestfs-out.json
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200313/a0bce737/attachment-0001.sig>


More information about the libvir-list mailing list