[libvirt PATCH 4/4] qemu: virtiofs: use a .log.fs suffix for logs

Ján Tomko jtomko at redhat.com
Mon Mar 23 16:10:37 UTC 2020


As Dave pointed out, someone creative might name a domain
to make its logfile conflict with a logfile of another
domain's virtiofsd log.

Signed-off-by: Ján Tomko <jtomko at redhat.com>
Reported-by: Dr. David Alan Gilbert <dgilbert at redhat.com>
---
 src/qemu/qemu_virtiofs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/qemu/qemu_virtiofs.c b/src/qemu/qemu_virtiofs.c
index aaa25bcbb8..575b47fd74 100644
--- a/src/qemu/qemu_virtiofs.c
+++ b/src/qemu/qemu_virtiofs.c
@@ -67,9 +67,9 @@ qemuVirtioFSCreateLogFilename(virQEMUDriverConfigPtr cfg,
 {
     g_autofree char *name = NULL;
 
-    name = g_strdup_printf("%s-%s", def->name, alias);
+    name = g_strdup_printf("%s-%s.log.fs", def->name, alias);
 
-    return virFileBuildPath(cfg->logDir, name, "-virtiofsd.log");
+    return virFileBuildPath(cfg->logDir, name, NULL);
 }
 
 
-- 
2.25.1




More information about the libvir-list mailing list