[PATCH] qemuCheckpointCreateXML: Check VM liveness first

Peter Krempa pkrempa at redhat.com
Thu Mar 26 17:21:43 UTC 2020


On Thu, Mar 26, 2020 at 12:13:52 -0500, Eric Blake wrote:
> On 3/26/20 12:08 PM, Peter Krempa wrote:
> > Move the liveness check prior to the capability check. If the VM is
> > offline the capabilities are not initialized and thus we'd report the
> > wrong error.
> > 
> > https://bugzilla.redhat.com/show_bug.cgi?id=1812531
> > 
> > Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> > ---
> >   src/qemu/qemu_checkpoint.c | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> We just did the same thing for CheckpointDelete :)

I noticed too late that there's another instance :)

> 
> Reviewed-by: Eric Blake <eblake at redhat.com>

Thanks




More information about the libvir-list mailing list