[PATCH v2 08/11] Revert "qemu_conf: Track embed root dir"

Daniel P. Berrangé berrange at redhat.com
Mon Mar 30 11:20:29 UTC 2020


On Thu, Mar 26, 2020 at 04:15:12PM +0100, Michal Privoznik wrote:
> This reverts commit 06a19921b6a522cd7b4d352c9320909752947de3.
> 
> What I haven't realized when writing this ^^ commit is that the
> virQEMUDriver structure already stores the root directory path.
> And since the pointer is immutable it can be accessed right from
> the structure and thus there is no need to duplicate it in the
> driver config.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> Reviewed-by: Andrea Bolognani <abologna at redhat.com>
> Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
> ---
>  src/qemu/qemu_conf.c | 2 --
>  src/qemu/qemu_conf.h | 2 --
>  2 files changed, 4 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list