[libvirt-jenkins-ci PATCH 3/7] lcitool: Create ccache wrappers outside of $HOME

[Daniel P. Berrangé]

On Fri, Mar 27, 2020 at 08:34:55PM +0100, Andrea Bolognani wrote:
> Having the wrappers inside $HOME works fine when we have control
> over which user will run the build, as is the case for the current
> Jenkins-based environment, but not when the user is chosen by an
> external entity, as is the case for container-based builds.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  guests/playbooks/update/main.yml            |  1 +
>  guests/playbooks/update/tasks/global.yml    | 14 ++++++++++++++
>  guests/playbooks/update/tasks/users.yml     | 21 ---------------------
>  guests/playbooks/update/templates/bashrc.j2 |  2 +-
>  4 files changed, 16 insertions(+), 22 deletions(-)
>  create mode 100644 guests/playbooks/update/tasks/global.yml

> diff --git a/guests/playbooks/update/tasks/global.yml b/guests/playbooks/update/tasks/global.yml
> new file mode 100644
> index 0000000..504a549
> --- /dev/null
> +++ b/guests/playbooks/update/tasks/global.yml
> @@ -0,0 +1,14 @@
> +---
> +- name: 'Create ccache wrappers'
> +  file:
> +    path: /usr/local/share/ccache-wrappers
> +    state: directory

I weakly suggest "/usr/local/share/ccache/bin"

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|