[PATCH 7/8] qemuDomainBlockCopyCommon: Record updated flags to block job

Ján Tomko jtomko at redhat.com
Mon Mar 9 12:17:10 UTC 2020


On a Friday in 2020, Peter Krempa wrote:
>For a long time we've masked out VIR_DOMAIN_BLOCK_COPY_SHALLOW if
>there's no backing chain for the copied disk to simplify the code.
>
>One of the refacors of caused that we no longer update the 'flags'
>variable just the local copies. This was okay until in ccd4228afff I
>started storing the job flags in the block job data.
>
>Given that we modify how we call qemu we also should modify @flags so
>that the correct value is recorded in the block job data.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_driver.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200309/960791aa/attachment-0001.sig>


More information about the libvir-list mailing list