[PATCH 4/5] qemu: capabilities: Introduce QEMU_CAPS_BLOCKDEV_SNAPSHOT_ALLOW_WRITE_ONLY

Eric Blake eblake at redhat.com
Wed Mar 11 16:00:38 UTC 2020


On 3/10/20 10:54 AM, Peter Krempa wrote:
> The capability is based on qemu's support of using blockdev-snapshot to
> install backing chain also for images which are in use by a block-copy
> job.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   src/qemu/qemu_capabilities.c                     | 2 ++
>   src/qemu/qemu_capabilities.h                     | 1 +
>   tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml | 1 +
>   3 files changed, 4 insertions(+)
> 
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index a75ca0574d..25a77c24af 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -565,6 +565,7 @@ VIR_ENUM_IMPL(virQEMUCaps,
>                 /* 355 */
>                 "vhost-user-fs",
>                 "query-named-block-nodes.flat",
> +              "blockdev-snapshot.allow-write-only-overlay",
>       );
> 
> 
> @@ -1442,6 +1443,7 @@ static struct virQEMUCapsStringFlags virQEMUCapsQMPSchemaQueries[] = {
>       { "human-monitor-command/$savevm-monitor-nodes", QEMU_CAPS_SAVEVM_MONITOR_NODES },
>       { "blockdev-add/arg-type/+nvme", QEMU_CAPS_DRIVE_NVME },
>       { "query-named-block-nodes/arg-type/flat", QEMU_CAPS_QMP_QUERY_NAMED_BLOCK_NODES_FLAT },
> +    { "blockdev-snapshot/$allow-write-only-overlay", QEMU_CAPS_BLOCKDEV_SNAPSHOT_ALLOW_WRITE_ONLY },

Matches the name in the qemu pull request.  Long line, but not the first 
such long line.

Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list