[PATCH v2 12/19] qemublocktest: Add tests for handling of bitmaps during block-commit

Eric Blake eblake at redhat.com
Wed Mar 11 21:01:50 UTC 2020


On 3/11/20 7:55 AM, Peter Krempa wrote:
> Add code for testing the two necessary steps of handling bitmaps during
> block commit and excercise the code on the test data which we have for

exercise

> bitmap handling.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   tests/qemublocktest.c                         |  95 ++++++++++++++
>   .../bitmapblockcommit/basic-1-2               | 119 ++++++++++++++++++
>   .../bitmapblockcommit/basic-1-3               | 119 ++++++++++++++++++
>   .../bitmapblockcommit/basic-2-3               |   2 +
>   4 files changed, 335 insertions(+)
>   create mode 100644 tests/qemublocktestdata/bitmapblockcommit/basic-1-2
>   create mode 100644 tests/qemublocktestdata/bitmapblockcommit/basic-1-3
>   create mode 100644 tests/qemublocktestdata/bitmapblockcommit/basic-2-3
> 

Impacted if my concerns earlier in the series about even needing to 
pre-disable bitmaps prior to a commit causes a change. But without a 
design change, this looks reasonable for covering the code just added.

Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list