[PATCH 11/30] qemuDomainSecretStorageSourcePrepare: Change aliases for disk secrets

Ján Tomko jtomko at redhat.com
Thu Mar 12 16:12:08 UTC 2020


On a Monday in 2020, Peter Krempa wrote:
>Originally there was only the secret for authentication so we didn't use
>any suffix to tell it apart. With the introduction of encryption we
>added a 'luks' suffix for the encryption secrets. Since encryption is
>really generic and authentication is not the only secret modify the
>aliases for the secrets to better describe what they are used for.
>
>This is possible as we store the disk secrets in the status XML thus
>only new machines will use the new secrets.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_domain.c                        |  4 +--
> ...-backing-chains-noindex.x86_64-2.12.0.args |  4 +--
> ...-backing-chains-noindex.x86_64-latest.args |  6 ++--
> ...sk-hostdev-scsi-virtio-iscsi-auth-AES.args |  6 ++--
> .../disk-network-iscsi.x86_64-2.12.0.args     | 12 +++----
> .../disk-network-iscsi.x86_64-latest.args     |  8 ++---
> .../disk-network-rbd.x86_64-2.12.0.args       |  4 +--
> .../disk-network-rbd.x86_64-latest.args       |  4 +--
> ...isk-network-source-auth.x86_64-2.12.0.args | 10 +++---
> ...isk-network-source-auth.x86_64-latest.args |  8 ++---
> .../disk-nvme.x86_64-latest.args              |  4 +--
> .../encrypted-disk-usage.args                 |  4 +--
> tests/qemuxml2argvdata/encrypted-disk.args    |  4 +--
> .../luks-disks-source-qcow2.args              | 24 +++++++-------
> ...luks-disks-source-qcow2.x86_64-latest.args | 32 +++++++++----------
> tests/qemuxml2argvdata/luks-disks-source.args | 26 ++++++++-------
> tests/qemuxml2argvdata/luks-disks.args        | 10 +++---
> tests/qemuxml2argvdata/user-aliases.args      |  4 +--
> 18 files changed, 90 insertions(+), 84 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200312/876b391f/attachment-0001.sig>


More information about the libvir-list mailing list