[PATCH] qemuDomainVcpuValidateConfig: Properly initialize 'firstcpu' variable

[Daniel Henrique Barboza]

On 3/17/20 2:50 PM, Peter Krempa wrote:
> The loop which checks whether the vcpus are in proper configuration for
> the requested hot(un)plug skips the first modified vcpu. This means
> that 'firstvcpu' which is used to print the error message in case the
> configuration is not suitable would never point to the first modified
> vcpu.
> 
> In cases such as:
> 
>    <vcpu placement='auto' current='5'>8</vcpu>
>    <vcpus>
>      <vcpu id='0' enabled='yes' hotpluggable='no'/>
>      <vcpu id='1' enabled='yes' hotpluggable='no'/>
>      <vcpu id='2' enabled='yes' hotpluggable='no'/>
>      <vcpu id='3' enabled='yes' hotpluggable='no'/>
>      <vcpu id='4' enabled='yes' hotpluggable='no'/>
>      <vcpu id='5' enabled='no' hotpluggable='yes'/>
>      <vcpu id='6' enabled='no' hotpluggable='yes'/>
>      <vcpu id='7' enabled='no' hotpluggable='yes'/>
>    </vcpus>
> 
>   # virsh setvcpu --config --disable  upstream 1
>   error: invalid argument: vcpu '-1' can't be modified as it is followed by non-hotpluggable online vcpus
> 
> After this fix the proper vcpu is reported in the error message:
> 
>   # virsh setvcpu --config --disable  upstream 1
>   error: invalid argument: vcpu '1' can't be modified as it is followed by non-hotpluggable online vcpu
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1611061
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>