[PATCH] commandtest: Fix test28 error detection

Daniel P. Berrangé berrange at redhat.com
Tue Mar 24 13:23:22 UTC 2020


On Tue, Mar 24, 2020 at 01:54:35PM +0100, Michal Privoznik wrote:
> As a part of c799d150d5e9dae I've introduced a test case that
> tests whether passing error object between processes works. The
> test spawns a child which reports a system error, parent process
> then reads the error and compares with expected output. Problem
> with this approach is that error message contains stringified
> errno which is not portable. FreeBSD has generally different
> messages than Linux. Therefore, use g_strerror() to do the errno
> to string translation for us.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  tests/commandtest.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list