[PATCH 1/1] qemu_domain.c: remove unneeded size check in NVDIMM alignment

Daniel Henrique Barboza danielhb413 at gmail.com
Wed Mar 25 14:15:14 UTC 2020


Commit 5540acb9a2b added a minimum size verification for the target
size of ppc64 NVDIMMs but forgot to remove a MAX() size check that
was being used in earlier reviews of that commit. The size
verification makes this check unneeded since we're making sure
that guestArea will always be at least equal to ppc64AlignSize.

Fixes: 5540acb9a2bd33fb97a7446a610b602c9e8629a3
Signed-off-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
---
 src/qemu/qemu_domain.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 2c9fb47d17..2c52778515 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -12639,8 +12639,6 @@ qemuDomainNVDimmAlignSizePseries(virDomainDefPtr def,
     }
 
     guestArea = (guestArea/ppc64AlignSize) * ppc64AlignSize;
-    guestArea = MAX(guestArea, ppc64AlignSize);
-
     mem->size = guestArea + mem->labelsize;
 
     return 0;
-- 
2.25.1





More information about the libvir-list mailing list