[PATCH 2/2] qemuSecurityChownCallback: Don't initialize storage file subsystem for local file

Peter Krempa pkrempa at redhat.com
Thu Mar 26 11:22:54 UTC 2020


On Thu, Mar 26, 2020 at 12:18:03 +0100, Peter Krempa wrote:
> virStorageFileSupportsSecurityDriver ends up initializing the storage
> file backend which after the recent changes to the daemon architecture
> may end up dlopening of the backend modules.
> 
> Since this is required only for remote storage we can optimize the call
> by moving the check whether the backend is supported to the branch which
> deals with remote storage. This will prevent the pointless dlopen for
> local files.
> 
> This is amplified by the fact that we now do most storage driver
> operations in forks so the storage backends may not even be initialized
> in the main daemon. On the other hand, not having gluster linked in the
> main daemon is a big win, so we should keep only the forks having to
> link with it.

Actually, I'll redact this as standard startup of a VM still invokes
the storage file backends, so they will be linked eventually on normal
usage. I've observed this after libvirtd restart.




More information about the libvir-list mailing list