[libvirt PATCH v3 12/12] gitlab: add explicit early job for syntax-check

Erik Skultety eskultet at redhat.com
Thu Mar 26 16:15:40 UTC 2020


On Thu, Mar 26, 2020 at 03:41:14PM +0100, Andrea Bolognani wrote:
> On Thu, 2020-03-26 at 12:35 +0000, Daniel P. Berrangé wrote:
> [...]
> > +codestyle:
>
> check-codestlye, maybe?
>
> > +  stage: prebuild
> > +  script:
> > +    - mkdir build
> > +    - cd build
> > +    - ../autogen.sh --prefix=$(pwd)/../vroot || (cat config.log && exit 1)
>
> Setting --prefix is not necessary for this job.
>
> With that dropped,
>
>   Reviewed-by: Andrea Bolognani <abologna at redhat.com>
>

Reviewed-by: Erik Skultety <eskultet at redhat.com>

--
Erik Skultety




More information about the libvir-list mailing list