[PATCH 2/2] qemuBackupBegin: Fix monitor access when rolling back due to failure

Peter Krempa pkrempa at redhat.com
Thu Mar 26 16:31:54 UTC 2020


On Thu, Mar 26, 2020 at 11:21:37 -0500, Eric Blake wrote:
> On 3/26/20 9:54 AM, Peter Krempa wrote:
> > The code attempting to clean up after a failed pull mode backup job
> > wrongly entered monitor but didn't clean up nor exit monitor due to a
> > logic bug. Fix the condition.
> > 
> > https://bugzilla.redhat.com/show_bug.cgi?id=1817327
> > 
> > Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> 
> Would be nice to mention which commit id introduced the bug.

Well, in this case you'll be fishing it out of a ~1k line additions
patch as it was introduced right together when the backup api
implementation was added in a1521f84a53.

I'll add the mention, but I didn't find it useful in this case.




More information about the libvir-list mailing list