[libvirt PATCH v3 11/12] gitlab: introduce a check for validate DCO sign-off

[Andrea Bolognani]

On Fri, 2020-03-27 at 10:53 +0000, Daniel P. Berrangé wrote:
> On Thu, Mar 26, 2020 at 06:06:37PM +0100, Andrea Bolognani wrote:
> > On Thu, 2020-03-26 at 12:35 +0000, Daniel P. Berrangé wrote:
> > > +            if "localhost" in line:
> > > +                print(" ❌ FAIL: bad email in %s" % line)
> > > +                errors = True
> > 
> > ... but if you absolutely must have them, at least don't try to mess
> > with indentation - aligning text and emoji is basically never going
> > to work reliably anyway. Please consider applying the diff at the
> > end of this message if you think dropping the emoji is not an option.
> 
> I wasn't actually trying to align them - the fail lines are
> intentionally indented, though not by enough.

Then indent them by 4 spaces or more. Anything less than that will
just look bad.

-- 
Andrea Bolognani / Red Hat / Virtualization