[libvirt-jenkins-ci PATCH 7/7] lcitool: Create and expose ccache wrappers
Daniel P. Berrangé
berrange at redhat.com
Mon Mar 30 12:23:52 UTC 2020
On Mon, Mar 30, 2020 at 02:21:19PM +0200, Andrea Bolognani wrote:
> On Mon, 2020-03-30 at 12:52 +0100, Daniel P. Berrangé wrote:
> > On Fri, Mar 27, 2020 at 08:34:59PM +0100, Andrea Bolognani wrote:
> > > sys.stdout.write(textwrap.dedent("""
> > > ENV LANG "en_US.UTF-8"
> > > + ENV PATH "/usr/local/share/ccache-wrappers:$PATH"
> >
> > I don't think we should do this though.
> >
> > When doing local container builds "make ci-build at BLAH" the container
> > content is throwaway, so using ccache is adding extra I/O to store
> > the cache arifacts but will not speed up compile as the cache will
> > always be initially empty.
> >
> > I think we only want to set $PATH in the .gitlab-ci.yml file where
> > we have explicitly provided a persistent cache to use.
>
> Sounds reasonable.
>
> We could still expose the path as something like
>
> ENV CCACHE_WRAPPERSDIR "/usr/local/share/ccache-wrappers"
>
> so that the CI rules would be able to do
>
> - export PATH="$CCACHE_WRAPPERSDIR:$PATH"
>
> instead of hardcoding the exact path. What do you think?
Sure, works for me.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
More information about the libvir-list
mailing list