[PATCH V3 5/5] cpu: Introduce getHost support for ARM CPU driver

Zhenyu Zheng zhengzhenyulixi at gmail.com
Wed May 6 01:15:30 UTC 2020


Thanks for the reply, any updates for the review?

On Wed, Apr 29, 2020 at 11:45 PM Jiri Denemark <jdenemar at redhat.com> wrote:

> Hi.
>
> On Wed, Apr 29, 2020 at 16:03:19 +0800, Zhenyu Zheng wrote:
> > Hi Jiri,
> >
> > Thanks alot for the help, I've updated the series to v4 and also attached
> > pipeline results for each patch as suggested.
>
> I explicitly said you don't have to send a new version just for that
> small issue...
>
> And I don't think pipeline results are needed for each patch, one result
> for the whole series should be enough to assure the code compiles on all
> tested architectures. Reviewers will usually check themselves whether
> the series can be compiled after each patch. I just wanted you to take
> the branch with all the patches and push it to gitlab, which will start
> a single CI pipeline for all the changes (just like in your v3), but the
> branch on gitlab will contain each patch of your series as is (while in
> v3 you squashed all patches into a single commit and pushed that).
>
> That said, all this is mainly a guidance for future submission. It's
> *not* a request for yet another respin of this series.
>
> In the meantime I found two AArch64 hosts with CPUs recognized by your
> changes so I'm playing with them.
>
> Jirka
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200506/fe601616/attachment-0001.htm>


More information about the libvir-list mailing list