[libvirt PATCH] tests: poison $HOME and $XDG_RUNTIME_DIR env variables
Andrea Bolognani
abologna at redhat.com
Wed May 6 13:07:15 UTC 2020
On Mon, 2020-05-04 at 15:39 +0100, Daniel P. Berrangé wrote:
> To attempt to catch unit tests which accidentally create files in $HOME,
> or $XDG_RUNTIME_DIR, poison these env vars by pointing them to
> directories which don't exist. This should give easier to debug test
> failures. For example:
>
> $ VIR_TEST_DEBUG=1 ./qemuhotplugtest
> Could not initialize HostdevManager - operation failed: Failed to create state dir '/bad-test-used-env-xdg-runtime-dir/libvirt/hostdevmgr'
>
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
> tests/testutils.c | 3 +++
> 1 file changed, 3 insertions(+)
This looks good, so
Reviewed-by: Andrea Bolognani <abologna at redhat.com>
but please don't merge it until
https://www.redhat.com/archives/libvir-list/2020-May/msg00212.html
is in or you'll break all builds :)
--
Andrea Bolognani / Red Hat / Virtualization
More information about the libvir-list
mailing list